Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Data/Set/Subset): simplify image_val_sUnion #12654

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(Data/Set/Subset): simplify image_val_sUnion #12654

wants to merge 2 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented May 4, 2024

Open in Gitpod

@mo271 mo271 added awaiting-review The author would like community review of the PR awaiting-CI labels May 4, 2024
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 5, 2024
@mo271 @Ruben-VandeVelde
Update Mathlib/Data/Set/Subset.lean
0ef851a 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@mo271 mo271 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 5, 2024
Ruben-VandeVelde
Ruben-VandeVelde approved these changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@sgouezel
Copy link
Contributor

sgouezel commented May 5, 2024

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 5, 2024
@mo271
chore(Data/Set/Subset): simplify image_val_sUnion (#12654)
8c8a6b1 
Co-authored-by: Moritz Firsching <firsching@google.com>
@mathlib-bors
Copy link

mathlib-bors bot commented May 5, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/Set/Subset): simplify image_val_sUnion [Merged by Bors] - chore(Data/Set/Subset): simplify image_val_sUnion May 5, 2024
@mathlib-bors mathlib-bors bot closed this May 5, 2024
@mathlib-bors mathlib-bors bot deleted the mo271/image_val_sUnion branch May 5, 2024 20:12
apnelson1 pushed a commit that referenced this pull request May 12, 2024
@mo271 @apnelson1
chore(Data/Set/Subset): simplify image_val_sUnion (#12654)
5c15e66 
Co-authored-by: Moritz Firsching <firsching@google.com>
callesonne pushed a commit that referenced this pull request May 16, 2024
@mo271 @callesonne
chore(Data/Set/Subset): simplify image_val_sUnion (#12654)
14de4c2 
Co-authored-by: Moritz Firsching <firsching@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees
No one assigned
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mo271 @sgouezel @Ruben-VandeVelde