Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor: make TProd reducible #12686

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

In various places we want TProd α (i :: is) = α i × TProd α to be transparent.


Open in Gitpod

In various places we want `TProd α (i :: is) = α i × TProd α` to be transparent.
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI labels May 5, 2024
@urkud
Copy link
Member

urkud commented May 6, 2024

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit d796e7d.
There were no significant changes against commit 7d9e677.

@urkud
Copy link
Member

urkud commented May 6, 2024

Thanks! 🎉
bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 6, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 6, 2024
In various places we want `TProd α (i :: is) = α i × TProd α` to be transparent.
@mathlib-bors
Copy link

mathlib-bors bot commented May 6, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor: make TProd reducible [Merged by Bors] - refactor: make TProd reducible May 6, 2024
@mathlib-bors mathlib-bors bot closed this May 6, 2024
@mathlib-bors mathlib-bors bot deleted the eric-wieser/tprod-reducible branch May 6, 2024 01:43
apnelson1 pushed a commit that referenced this pull request May 12, 2024
In various places we want `TProd α (i :: is) = α i × TProd α` to be transparent.
callesonne pushed a commit that referenced this pull request May 16, 2024
In various places we want `TProd α (i :: is) = α i × TProd α` to be transparent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants