Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: add Nat.le_self_pow #1273

Closed
wants to merge 4 commits into from
Closed

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 30, 2022

This is the Lean 4 version of leanprover-community/mathlib#18022

@urkud urkud added the awaiting-review The author would like community review of the PR label Dec 30, 2022
@Ruben-VandeVelde Ruben-VandeVelde added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Dec 31, 2022
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Dec 31, 2022
@hrmacbeth hrmacbeth added the mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged label Jan 2, 2023
@semorrison
Copy link
Contributor

bors d+

Please merge when the mathlib3 PR is approved.

@bors
Copy link

bors bot commented Jan 6, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Jan 6, 2023
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Jan 6, 2023
* Add `nat.le_self_pow`, `polynomial.sub_one_pow_totient_le_cyclotomic_eval`, `polynomial.cyclotomic_eval_le_add_one_pow_totient`, `polynomial.sub_one_pow_totient_lt_nat_abs_cyclotomic_eval`, `zmod.order_of_units_dvd_card_sub_one`, and `zmod.order_of_dvd_card_sub_one`.
* Rename `polynomial.cyclotomic_eval_lt_sub_one_pow_totient` to `polynomial.cyclotomic_eval_lt_add_one_pow_totient`.
* Replace `nat.exists_prime_ge_modeq_one` with `nat.exists_prime_gt_modeq_one`.
* Assume `≠ 0` instead of `0 <` in `nat.exists_prime_ge_modeq_one` etc.
* Golf some proofs.

Mathlib 4 version: leanprover-community/mathlib4#1273
@urkud
Copy link
Member Author

urkud commented Jan 7, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 7, 2023
bors bot pushed a commit that referenced this pull request Jan 7, 2023
This is the Lean 4 version of leanprover-community/mathlib#18022

Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 7, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: add Nat.le_self_pow [Merged by Bors] - feat: add Nat.le_self_pow Jan 7, 2023
@bors bors bot closed this Jan 7, 2023
@bors bors bot deleted the YK-le-self-pow branch January 7, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants