[Merged by Bors] - feat: Port RingTheory/RingInvo #1276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aricursion
added
question
mathlib-port
semorrison
added
the
merge-conflict
semorrison
removed
the
merge-conflict
mo271
reviewed
Jan 7, 2023
Mathlib/RingTheory/RingInvo.lean
Outdated
Comment on lines
74
to
77
| @[simp] | ||
| theorem map_eq_zero_iff (f : RingInvo R) {x : R} : f x = 0 ↔ x = 0 := | ||
| f.toRingEquiv.map_eq_zero_iff | ||
| #align ring_invo.map_eq_zero_iff RingInvo.map_eq_zero_iff |
There was a problem hiding this comment.
Suggested change
| @[simp] | |
| theorem map_eq_zero_iff (f : RingInvo R) {x : R} : f x = 0 ↔ x = 0 := | |
| f.toRingEquiv.map_eq_zero_iff | |
| #align ring_invo.map_eq_zero_iff RingInvo.map_eq_zero_iff | |
| /- Porting note `simp` attribute removed as suggested by linter: | |
| simp can prove this: | |
| by simp only [AddEquivClass.map_eq_zero_iff] | |
| #noalign ring_invo.map_eq_zero_iff |
Again I'm not sure how to handle the linter error here correcty. If one replaces f x by f.toRingEquiv as above, the linter says it is no needed anymore.
LukasMias
added
merge-conflict
|
The whole RingInvoClass business needs to be backported before we can merge this PR. The mathlib3 PR for this is found here. I'm removing the WIP, help, and question tags because I think this PR is finished up to these changes. |
LukasMias
removed
help-wanted
The mathlib3 PR is merged now! I will wait to see how mathport translates that file once that happens, and then we can finish things up here :) |
LukasMias
added
awaiting-review
semorrison
added
the
merge-conflict
|
All that's left is to decide whether we want |
aricursion
removed
the
merge-conflict
jcommelin
reviewed
Jan 19, 2023
jcommelin
added
awaiting-author
Co-authored-by: Johan Commelin <johan@commelin.net>
…unity/mathlib4 into port/RingTheory.RingInvo
LukasMias
added
awaiting-review
semorrison
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 27, 2023
Everything compiles properly, not done with style/removing unnecisary lemmas Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: qawbecrdtey <qawbecrdtey@kaist.ac.kr> Co-authored-by: Lukas Miaskiwskyi <lukas.mias@gmail.com> Co-authored-by: z <32079362+zaxioms@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything compiles properly, not done with style/removing unnecisary lemmas