[Merged by Bors] - chore: Move basic Int lemmas earlier
#12821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bunch of lemmas about `Int` can be moved to `Data.Int.Defs` at little cost. This PR moves them and deletes the now empty `Data.Int.Dvd.Basic`. The story is that those lemmas used to rely on lemmas proved for algebraic order structures, hence required the algebraic order instances on `Int` to be available. In Lean 4, those preliminary lemmas have been special-cased to `Nat` and `Int`, so there is no need for the general instances anymore (at least in basic files).
YaelDillies
added
awaiting-review
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
2 tasks
|
Ruben-VandeVelde
approved these changes
May 15, 2024
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
|
Merge conflict. |
leanprover-community-mathlib4-bot
added
the
merge-conflict
YaelDillies
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 16, 2024
A bunch of lemmas about `Int` can be moved to `Data.Int.Defs` at little cost. This PR moves them and deletes the now empty `Data.Int.Div` and `Data.Int.Dvd.Basic`. The story is that those lemmas used to rely on lemmas proved for algebraic order structures, hence required the algebraic order instances on `Int` to be available. In Lean 4, those preliminary lemmas have been special-cased to `Nat` and `Int`, so there is no need for the general instances anymore (at least in basic files).
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Int lemmas earlierInt lemmas earlier
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
A bunch of lemmas about `Int` can be moved to `Data.Int.Defs` at little cost. This PR moves them and deletes the now empty `Data.Int.Div` and `Data.Int.Dvd.Basic`. The story is that those lemmas used to rely on lemmas proved for algebraic order structures, hence required the algebraic order instances on `Int` to be available. In Lean 4, those preliminary lemmas have been special-cased to `Nat` and `Int`, so there is no need for the general instances anymore (at least in basic files).
grunweg
pushed a commit
that referenced
this pull request
May 17, 2024
A bunch of lemmas about `Int` can be moved to `Data.Int.Defs` at little cost. This PR moves them and deletes the now empty `Data.Int.Div` and `Data.Int.Dvd.Basic`. The story is that those lemmas used to rely on lemmas proved for algebraic order structures, hence required the algebraic order instances on `Int` to be available. In Lean 4, those preliminary lemmas have been special-cased to `Nat` and `Int`, so there is no need for the general instances anymore (at least in basic files).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of lemmas about
Intcan be moved toData.Int.Defsat little cost. This PR moves them and deletes the now emptyData.Int.DivandData.Int.Dvd.Basic.The story is that those lemmas used to rely on lemmas proved for algebraic order structures, hence required the algebraic order instances on
Intto be available. In Lean 4, those preliminary lemmas have been special-cased toNatandInt, so there is no need for the general instances anymore (at least in basic files).