Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: Delete Algebra.GroupWithZero.Power #12825

Closed
wants to merge 10 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented May 11, 2024

After #12736, all lemmas in Algebra.GroupWithZero.Power can move to the earlier files where they belong. The changes to their proofs are minimal. It's just a matter of using the new Lean 4 Nat- and Int-specific lemmas instead of the generic algebraic order ones.


Open in Gitpod

Move a bunch of `pow` lemmas from `Algebra.Group.Commute.Defs` and `Algebra.GroupPower.Basic` to `Algebra.Group.Defs` and `Algebra.Group.Basic` with little to no changes to their proofs.
After #12736, all lemmas in `Algebra.GroupWithZero.Power` can move to the earlier files where they belong. The changes to their proofs are minimal. It's just a matter of using the new Lean 4 `Nat`- and `Int`-specific lemmas instead of the generic algebraic order ones.
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels May 11, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. blocked-by-other-PR This PR depends on another PR to Mathlib labels May 11, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 11, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib label May 13, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

Copy link

  • + self_zpow₀
  • + zpow_left₀
  • + zpow_self₀
  • + zpow_zpow_self₀
  • + zpow_zpow₀
  • +``+ zpow_right₀
  • - Commute.self_zpow₀
  • - Commute.zpow_left₀
  • - Commute.zpow_right₀
  • - Commute.zpow_self₀
  • - Commute.zpow_zpow_self₀
  • - Commute.zpow_zpow₀
  • - SemiconjBy.zpow_right₀

Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, assuming it builds. Thanks!

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@sgouezel
Copy link
Contributor

bors r+

mathlib-bors bot pushed a commit that referenced this pull request May 13, 2024
After #12736, all lemmas in `Algebra.GroupWithZero.Power` can move to the earlier files where they belong. The changes to their proofs are minimal. It's just a matter of using the new Lean 4 `Nat`- and `Int`-specific lemmas instead of the generic algebraic order ones.
@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 13, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 13, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Delete Algebra.GroupWithZero.Power [Merged by Bors] - chore: Delete Algebra.GroupWithZero.Power May 13, 2024
@mathlib-bors mathlib-bors bot closed this May 13, 2024
@mathlib-bors mathlib-bors bot deleted the delete_group_with_zero_power branch May 13, 2024 12:50
callesonne pushed a commit that referenced this pull request May 16, 2024
After #12736, all lemmas in `Algebra.GroupWithZero.Power` can move to the earlier files where they belong. The changes to their proofs are minimal. It's just a matter of using the new Lean 4 `Nat`- and `Int`-specific lemmas instead of the generic algebraic order ones.
grunweg pushed a commit that referenced this pull request May 17, 2024
After #12736, all lemmas in `Algebra.GroupWithZero.Power` can move to the earlier files where they belong. The changes to their proofs are minimal. It's just a matter of using the new Lean 4 `Nat`- and `Int`-specific lemmas instead of the generic algebraic order ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants