Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.Ring.AddAut #1284

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port Algebra.Ring.AddAut #1284

wants to merge 5 commits into from

Conversation

winston-h-zhang
Copy link
Collaborator

@winston-h-zhang winston-h-zhang commented Jan 1, 2023 •
edited by bors bot

No description provided.

@winston-h-zhang winston-h-zhang changed the title feat: port/Algebra.Ring.AddAut feat: port Algebra.Ring.AddAut Jan 1, 2023
@winston-h-zhang winston-h-zhang self-assigned this Jan 1, 2023
@winston-h-zhang winston-h-zhang added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Jan 1, 2023
dupuisf
dupuisf reviewed Jan 1, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor naming changes, but otherwise looks good!

bors d+

Mathlib/Algebra/Ring/AddAut.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Ring/AddAut.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 1, 2023

✌️ winston-h-zhang can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jan 1, 2023
@winston-h-zhang @dupuisf
Apply suggestions from code review
ca2ceef 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@winston-h-zhang
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jan 1, 2023
@winston-h-zhang
feat: port Algebra.Ring.AddAut (#1284)
ee976b4
@bors
Copy link

bors bot commented Jan 1, 2023

Build failed:

  • Build

@winston-h-zhang
Copy link
Collaborator Author

bors +r

@bors
Copy link

bors bot commented Jan 1, 2023

Did you mean "r+"?

@winston-h-zhang
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jan 1, 2023
@winston-h-zhang
feat: port Algebra.Ring.AddAut (#1284)
9c30fc2
@bors
Copy link

bors bot commented Jan 1, 2023

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@bors bors bot changed the title feat: port Algebra.Ring.AddAut [Merged by Bors] - feat: port Algebra.Ring.AddAut Jan 1, 2023
@bors bors bot closed this Jan 1, 2023
@bors bors bot deleted the port/Algebra.Ring.AddAut branch January 1, 2023 20:39
@github-actions github-actions bot mentioned this pull request Jan 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees

@winston-h-zhang winston-h-zhang

Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@winston-h-zhang @dupuisf @semorrison