-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: Separate algebraic multiset lemmas #12845
Conversation
4972a17
to
7dc1961
Compare
According to a rough "auto-diff", no declarations were lost and the only added one is |
This PR/issue depends on:
|
c14c2fd
to
7697dd6
Compare
125001b
to
e2974c6
Compare
You can run this locally as follows ## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintainer merge
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Thanks 🎉 bors merge |
Resplit `Algebra.BigOperators.Multiset.Basic` and `Algebra.BigOperators.Multiset.Lemmas` into two new files: * `Algebra.BigOperators.Group.Multiset` for lemmas that require group-like structures (`Monoid`, `Group`, ...) * `Algebra.BigOperators.Ring.Multiset` for lemmas that require ring-like structures (`MonoidWithZero`, `Ring`, ...) Add `assert_not_exists Ring` in the former. Once #12974 lands, it will be strenghtenable to `assert_not_exists MonoidWithZero`.
Pull request successfully merged into master. Build succeeded: |
Resplit `Algebra.BigOperators.Multiset.Basic` and `Algebra.BigOperators.Multiset.Lemmas` into two new files: * `Algebra.BigOperators.Group.Multiset` for lemmas that require group-like structures (`Monoid`, `Group`, ...) * `Algebra.BigOperators.Ring.Multiset` for lemmas that require ring-like structures (`MonoidWithZero`, `Ring`, ...) Add `assert_not_exists Ring` in the former. Once #12974 lands, it will be strenghtenable to `assert_not_exists MonoidWithZero`.
Resplit `Algebra.BigOperators.Multiset.Basic` and `Algebra.BigOperators.Multiset.Lemmas` into two new files: * `Algebra.BigOperators.Group.Multiset` for lemmas that require group-like structures (`Monoid`, `Group`, ...) * `Algebra.BigOperators.Ring.Multiset` for lemmas that require ring-like structures (`MonoidWithZero`, `Ring`, ...) Add `assert_not_exists Ring` in the former. Once #12974 lands, it will be strenghtenable to `assert_not_exists MonoidWithZero`.
Resplit
Algebra.BigOperators.Multiset.Basic
andAlgebra.BigOperators.Multiset.Lemmas
into two new files:Algebra.BigOperators.Group.Multiset
for lemmas that require group-like structures (Monoid
,Group
, ...)Algebra.BigOperators.Ring.Multiset
for lemmas that require ring-like structures (MonoidWithZero
,Ring
, ...)Add
assert_not_exists Ring
in the former. Once #12974 lands, it will be strenghtenable toassert_not_exists MonoidWithZero
.