[Merged by Bors] - feat(AlgebraicGeometry/Morphisms): define closed immersions #12917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: 101damnations <101damnations@github.com>
Because of explicit encouragement of Amelia.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
chrisflav
added
awaiting-review
|
Thanks! I have some thoughts on how we should define closed immersions, but they require a substantial more work and should not block this. We can refactor this later when the time comes. |
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
kbuzzard
reviewed
May 24, 2024
|
Thanks a lot! bors d+ |
|
✌️ chrisflav can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 24, 2024
Defines closed immersions of schemes. Co-authored-by: Amelia Livingston @101damnations Co-authored-by: Jonas van der Schaaf @jonasvanderschaaf Co-authored-by: 101damnations <101damnations@github.com> Co-authored-by: Christian Merten <christian@merten.dev>
|
Thanks for the reviews! |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
grunweg
pushed a commit
that referenced
this pull request
May 24, 2024
Defines closed immersions of schemes. Co-authored-by: Amelia Livingston @101damnations Co-authored-by: Jonas van der Schaaf @jonasvanderschaaf Co-authored-by: 101damnations <101damnations@github.com> Co-authored-by: Christian Merten <christian@merten.dev>
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
Defines closed immersions of schemes. Co-authored-by: Amelia Livingston @101damnations Co-authored-by: Jonas van der Schaaf @jonasvanderschaaf Co-authored-by: 101damnations <101damnations@github.com> Co-authored-by: Christian Merten <christian@merten.dev>
js2357
pushed a commit
that referenced
this pull request
Jun 18, 2024
Defines closed immersions of schemes. Co-authored-by: Amelia Livingston @101damnations Co-authored-by: Jonas van der Schaaf @jonasvanderschaaf Co-authored-by: 101damnations <101damnations@github.com> Co-authored-by: Christian Merten <christian@merten.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines closed immersions of schemes.
Co-authored-by: Amelia Livingston @101damnations
Co-authored-by: Jonas van der Schaaf @jonasvanderschaaf
This is a reopening and clean up of #6135. The original author is Jonas van der Schaaf who no longer wanted to pursue this PR.