[Merged by Bors] - chore: Remove order dependencies to Data.Fin.Basic
#13005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all the declarations using the mathlib order hierarchy to a new file `Order.Fin`. There were a bunch of order embeddings in `Data.Fin.Basic`, so I kept an embedding version of them around and renamed the order embedding version.
YaelDillies
added
awaiting-review
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
dupuisf
reviewed
May 23, 2024
There's no meaningul |
Fair enough. |
|
bors r+ |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 23, 2024
Move all the declarations using the mathlib order hierarchy to a new file `Order.Fin`. There were a bunch of order embeddings in `Data.Fin.Basic`, so I kept an embedding version of them around and renamed the order embedding version.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Data.Fin.BasicData.Fin.Basic
grunweg
pushed a commit
that referenced
this pull request
May 24, 2024
Move all the declarations using the mathlib order hierarchy to a new file `Order.Fin`. There were a bunch of order embeddings in `Data.Fin.Basic`, so I kept an embedding version of them around and renamed the order embedding version.
Ruben-VandeVelde
added a commit
that referenced
this pull request
May 30, 2024
This was removed in #13005.
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 30, 2024
This was removed in #13005.
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
Move all the declarations using the mathlib order hierarchy to a new file `Order.Fin`. There were a bunch of order embeddings in `Data.Fin.Basic`, so I kept an embedding version of them around and renamed the order embedding version.
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
This was removed in #13005.
js2357
pushed a commit
that referenced
this pull request
Jun 18, 2024
Move all the declarations using the mathlib order hierarchy to a new file `Order.Fin`. There were a bunch of order embeddings in `Data.Fin.Basic`, so I kept an embedding version of them around and renamed the order embedding version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all the declarations using the mathlib order hierarchy to a new file
Order.Fin. There were a bunch of order embeddings inData.Fin.Basic, so I kept an embedding version of them around and renamed the order embedding version.