Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port GroupTheory.Submonoid.Center #1315

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat: port GroupTheory.Submonoid.Center #1315

wants to merge 3 commits into from

Conversation

dupuisf
Copy link
Contributor

@dupuisf dupuisf commented Jan 3, 2023 •
edited

Also includes fixes in other files as well (Set.Center to Set.center and a few more like that).

@dupuisf dupuisf added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 3, 2023
@dupuisf dupuisf added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 3, 2023
hrmacbeth
hrmacbeth reviewed Jan 3, 2023
View reviewed changes
Copy link
Member

@hrmacbeth hrmacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit surprised that it was .center rather than .Center, but after a close read of the naming convention I agree with you. So I learned something new today!

bors r+

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 3, 2023
bors bot pushed a commit that referenced this pull request Jan 3, 2023
@dupuisf
feat: port GroupTheory.Submonoid.Center (#1315)
f6c80f8 
Also includes fixes in other files as well (`Set.Center` to `Set.center` and a few more like that).
@dupuisf
Copy link
Contributor Author

dupuisf commented Jan 3, 2023

I was a bit surprised that it was .center rather than .Center, but after a close read of the naming convention I agree with you. So I learned something new today!

I think mathport is pretty much guaranteed to make the right choice between snake_case, lowerCamelCase and UpperCamelCase, but the details might be wrong.

@bors
Copy link

bors bot commented Jan 3, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port GroupTheory.Submonoid.Center [Merged by Bors] - feat: port GroupTheory.Submonoid.Center Jan 3, 2023
@bors bors bot closed this Jan 3, 2023
@bors bors bot deleted the port/GroupTheory.Submonoid.Center branch January 3, 2023 22:57
@hrmacbeth hrmacbeth mentioned this pull request Jan 5, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrmacbeth hrmacbeth hrmacbeth left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dupuisf @hrmacbeth @semorrison