-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: replace many refine'
with refine
#13166
Conversation
!bench |
Here are the benchmark results for commit 6beb1d0.Found no runs to compare against. |
!Stoll-bench @MichaelStollBayreuth |
No declarations were harmed in the making of this PR! 🐙 You can run this locally as follows ## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Benchmark using master from a couple of commits ago (thanks Matt!). |
Unfortunately, |
@MichaelStollBayreuth, Matt provided a better bench that I linked shortly before you posted your comment: does that benchmark help? |
@adomani That's the one I was trying. |
Oh, sorry, I clicked on the link and I could see nothing. |
Ok, I removed the lines starting with whitespace, an optional dot, optional whitespace, and then bors merge p=90001 |
This PR replaces 7979 `refine'` with `refine`. Many of the left-over ones cannot actually be directly replaced by `refine <add some ?>`. [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.2313166.20.60refine'.60.20to.20.60refine.60)
Pull request successfully merged into master. Build succeeded: |
refine'
with refine
refine'
with refine
This PR replaces 7979 `refine'` with `refine`. Many of the left-over ones cannot actually be directly replaced by `refine <add some ?>`. [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.2313166.20.60refine'.60.20to.20.60refine.60)
This PR replaces 7979 `refine'` with `refine`. Many of the left-over ones cannot actually be directly replaced by `refine <add some ?>`. [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.2313166.20.60refine'.60.20to.20.60refine.60)
This PR replaces 7979 `refine'` with `refine`. Many of the left-over ones cannot actually be directly replaced by `refine <add some ?>`. [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.2313166.20.60refine'.60.20to.20.60refine.60)
This PR replaces 7979
refine'
withrefine
. Many of the left-over ones cannot actually be directly replaced byrefine <add some ?>
.Zulip thread