Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: replace many refine' with refine #13166

Closed
wants to merge 3 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented May 24, 2024

This PR replaces 7979 refine' with refine. Many of the left-over ones cannot actually be directly replaced by refine <add some ?>.

Zulip thread


Open in Gitpod

@adomani adomani added the awaiting-review The author would like community review of the PR label May 24, 2024
@adomani
Copy link
Collaborator Author

adomani commented May 24, 2024

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 6beb1d0.Found no runs to compare against.

@kbuzzard
Copy link
Member

!Stoll-bench @MichaelStollBayreuth

Copy link

No declarations were harmed in the making of this PR! 🐙


You can run this locally as follows

## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@adomani
Copy link
Collaborator Author

adomani commented May 24, 2024

@MichaelStollBayreuth
Copy link
Collaborator

Unfortunately, http://speed.lean-fro.org/mathlib4/compare/e7b27246-a3e6-496a-b552-ff4b45c7236e/to/7154f447-eacb-45e1-b172-599fa45c4fa8?all_values=true does not work here (which is how my script gets the json file with the information). If someone knowns the right incantation for this case, I can produce a more detailed summary.

@adomani
Copy link
Collaborator Author

adomani commented May 24, 2024

@MichaelStollBayreuth, Matt provided a better bench that I linked shortly before you posted your comment: does that benchmark help?

@MichaelStollBayreuth
Copy link
Collaborator

@adomani That's the one I was trying.

@adomani
Copy link
Collaborator Author

adomani commented May 24, 2024

Oh, sorry, I clicked on the link and I could see nothing.

@mattrobball
Copy link
Collaborator

Ok, I removed the lines starting with whitespace, an optional dot, optional whitespace, and then refine. This left about 2k lines of the diff. I went through those ?_ by ?_ to make sure nothing was off.

bors merge p=90001

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 24, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 24, 2024
This PR replaces 7979 `refine'` with `refine`.  Many of the left-over ones cannot actually be directly replaced by `refine <add some ?>`.

[Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.2313166.20.60refine'.60.20to.20.60refine.60)
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 24, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: replace many refine' with refine [Merged by Bors] - chore: replace many refine' with refine May 24, 2024
@mathlib-bors mathlib-bors bot closed this May 24, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/refine_to_refine branch May 24, 2024 17:05
@adomani adomani mentioned this pull request May 24, 2024
grunweg pushed a commit that referenced this pull request May 24, 2024
This PR replaces 7979 `refine'` with `refine`.  Many of the left-over ones cannot actually be directly replaced by `refine <add some ?>`.

[Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.2313166.20.60refine'.60.20to.20.60refine.60)
mathlib-bors bot pushed a commit that referenced this pull request May 30, 2024
A PR analogous to #13166.  The reason some of these `refine'` are now caught is that my previous script missed all instances.  I am not sure why it is still missing other `refine'`.



Co-authored-by: Michael Rothgang <rothgami@math.hu-berlin.de>
callesonne pushed a commit that referenced this pull request Jun 4, 2024
This PR replaces 7979 `refine'` with `refine`.  Many of the left-over ones cannot actually be directly replaced by `refine <add some ?>`.

[Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.2313166.20.60refine'.60.20to.20.60refine.60)
callesonne pushed a commit that referenced this pull request Jun 4, 2024
A PR analogous to #13166.  The reason some of these `refine'` are now caught is that my previous script missed all instances.  I am not sure why it is still missing other `refine'`.



Co-authored-by: Michael Rothgang <rothgami@math.hu-berlin.de>
js2357 pushed a commit that referenced this pull request Jun 18, 2024
This PR replaces 7979 `refine'` with `refine`.  Many of the left-over ones cannot actually be directly replaced by `refine <add some ?>`.

[Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.2313166.20.60refine'.60.20to.20.60refine.60)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants