Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Data.Set.Intervals.IsoIoo #1321

Closed
wants to merge 7 commits into from

Conversation

maxwell-thum
Copy link
Collaborator

@maxwell-thum maxwell-thum commented Jan 3, 2023

Original imports Mathlib.Tactic.FieldSimp which is not yet ported. I'm going to try to do this without the tactic.

@maxwell-thum maxwell-thum changed the title Port/data.set.intervals.iso ioo feat: port data.set.intervals.iso ioo Jan 3, 2023
@maxwell-thum maxwell-thum changed the title feat: port data.set.intervals.iso ioo feat: port data.set.intervals.iso_ioo Jan 3, 2023
@maxwell-thum maxwell-thum added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 3, 2023
@maxwell-thum maxwell-thum changed the title feat: port data.set.intervals.iso_ioo feat: port data.set.intervals.iso_Ioo Jan 3, 2023
@maxwell-thum maxwell-thum deleted the port/Data.Set.Intervals.IsoIoo branch January 3, 2023 23:49
@maxwell-thum maxwell-thum restored the port/Data.Set.Intervals.IsoIoo branch January 14, 2023 08:50
@maxwell-thum maxwell-thum reopened this Jan 14, 2023
@maxwell-thum maxwell-thum added the help-wanted The author needs attention to resolve issues label Jan 14, 2023
@maxwell-thum maxwell-thum removed the help-wanted The author needs attention to resolve issues label Jan 14, 2023
@maxwell-thum maxwell-thum added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 15, 2023
@maxwell-thum maxwell-thum changed the title feat: port data.set.intervals.iso_Ioo feat: port Data.Set.Intervals.IsoIoo Jan 15, 2023
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Data/Set/Intervals/IsoIoo.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 15, 2023

✌️ maxwell-thum can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jan 15, 2023
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@maxwell-thum
Copy link
Collaborator Author

✌️ maxwell-thum can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

bors r+

bors bot pushed a commit that referenced this pull request Jan 16, 2023
Original imports `Mathlib.Tactic.FieldSimp` which is not yet ported. I'm going to try to do this without the tactic.

Co-authored-by: maxwell-thum <119913396+maxwell-thum@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 16, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Set.Intervals.IsoIoo [Merged by Bors] - feat: port Data.Set.Intervals.IsoIoo Jan 16, 2023
@bors bors bot closed this Jan 16, 2023
@bors bors bot deleted the port/Data.Set.Intervals.IsoIoo branch January 16, 2023 03:34
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
Original imports `Mathlib.Tactic.FieldSimp` which is not yet ported. I'm going to try to do this without the tactic.

Co-authored-by: maxwell-thum <119913396+maxwell-thum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants