-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Algebra/Lie/Semisimple): API for semisimple Lie algebras #13217
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice!
I only have time for some superficial remarks now. My main thought is whether some of the proofs could be golfed by using more of the results about compactly-generated lattices.
I'll have more to say later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is marvelous!
bors d+
Mathlib/Order/BooleanGenerators.lean
Outdated
exact (hS.mono hX).isAtom a ha | ||
|
||
lemma complementedLattice_of_sSup_eq_top (h : sSup S = ⊤) : ComplementedLattice α := by | ||
constructor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't help wondering if it might be easier to establish modularity instead. So the proof would start:
constructor | |
suffices IsModularLattice α by | |
have _i := isAtomistic_of_sSup_eq_top hS h | |
apply complementedLattice_of_isAtomistic |
More generally I'm not sure what order to establish properties would minimize the effort here (e.g., could we establish complementarity first and then get atomisticness from complementedLattice_iff_isAtomistic
etc.).
However what you have is clearly fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion! By putting DistribLattice higher about, I could apply this golf. (It implies modular lattice.)
✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with |
If you have the appetite I think a nice future refactor would be to remove: import Mathlib.Algebra.Lie.Solvable and move all the dependent material ( For bonus points, I think we should also remove this import from |
Co-authored-by: Oliver Nash <github@olivernash.org>
bors r+ |
Including the result that ideals in a semisimple Lie algebra are in a unique way the direct sum of simple ideals. This result makes no assumptions on the ring of coefficients or the Lie algebra; it holds over arbitrary base rings, and in arbitrary dimensions.
Pull request successfully merged into master. Build succeeded: |
Including the result that ideals in a semisimple Lie algebra are in a unique way the direct sum of simple ideals. This result makes no assumptions on the ring of coefficients or the Lie algebra; it holds over arbitrary base rings, and in arbitrary dimensions.
Including the result that ideals in a semisimple Lie algebra are in a unique way the direct sum of simple ideals. This result makes no assumptions on the ring of coefficients or the Lie algebra; it holds over arbitrary base rings, and in arbitrary dimensions.
Including the result that ideals in a semisimple Lie algebra
are in a unique way the direct sum of simple ideals.
This result makes no assumptions on the ring of coefficients or the Lie algebra;
it holds over arbitrary base rings, and in arbitrary dimensions.