[Merged by Bors] - chore: remove superfluous imports from runLinter
#1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 4, 2023
`Mathlib.Data.Array.Defs` is currently an empty file, because its contents have been upstreamed to Std, but it had `import Std` in it which means that building the linter requires compiling all of `Std`, which is not necessary. This is especially obvious now that builds are being cached since the only part that is not cached is the compilation of the C files.
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
runLinterrunLinter
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mathlib.Data.Array.Defsis currently an empty file, because its contents have been upstreamed to Std, but it hadimport Stdin it which means that building the linter requires compiling all ofStd, which is not necessary. This is especially obvious now that builds are being cached since the only part that is not cached is the compilation of the C files.