Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: Split Algebra.Function.Support/Algebra.Function.Indicator #13244

Closed
wants to merge 3 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented May 26, 2024

... in a file about Group and another one about GroupWithZero. Credit Yury for leanprover-community/mathlib#2340 and Zhouhang for leanprover-community/mathlib#1949.


Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels May 26, 2024
@leanprover-community leanprover-community deleted a comment from github-actions bot May 26, 2024
@leanprover-community leanprover-community deleted a comment from github-actions bot May 26, 2024
... in a file about `Group` and another one about `GroupWithZero`.
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this on the maintainer queue after fixing these:

Mathlib/Algebra/Group/Indicator.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Order/Group/Indicator.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Order/Group/Indicator.lean Outdated Show resolved Hide resolved
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@YaelDillies
Copy link
Collaborator Author

Great, thanks!

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@sgouezel
Copy link
Contributor

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 27, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 27, 2024
…13244)

... in a file about `Group` and another one about `GroupWithZero`. Credit Yury for leanprover-community/mathlib#2340 and Zhouhang for leanprover-community/mathlib#1949.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 27, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Split Algebra.Function.Support/Algebra.Function.Indicator [Merged by Bors] - chore: Split Algebra.Function.Support/Algebra.Function.Indicator May 27, 2024
@mathlib-bors mathlib-bors bot closed this May 27, 2024
@mathlib-bors mathlib-bors bot deleted the split_function_support branch May 27, 2024 13:31
callesonne pushed a commit that referenced this pull request Jun 4, 2024
…13244)

... in a file about `Group` and another one about `GroupWithZero`. Credit Yury for leanprover-community/mathlib#2340 and Zhouhang for leanprover-community/mathlib#1949.
js2357 pushed a commit that referenced this pull request Jun 18, 2024
…13244)

... in a file about `Group` and another one about `GroupWithZero`. Credit Yury for leanprover-community/mathlib#2340 and Zhouhang for leanprover-community/mathlib#1949.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants