Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: add PUnit/PEmpty to additive dict #1330

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix: add PUnit/PEmpty to additive dict #1330

wants to merge 1 commit into from

Conversation

fpvandoorn
Copy link
Member

This should fix the problems in #1319

@fpvandoorn fpvandoorn added awaiting-review The author would like community review of the PR t-meta Tactics, attributes or user commands labels Jan 4, 2023
@arienmalec arienmalec mentioned this pull request Jan 4, 2023
Closed
2 tasks
@gebner
Copy link
Member

gebner commented Jan 6, 2023

We have the same attributes in mathlib3.

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 6, 2023
bors bot pushed a commit that referenced this pull request Jan 6, 2023
@fpvandoorn
fix: add PUnit/PEmpty to additive dict (#1330)
8dd499b 
This should fix the problems in [#1319](#1319)
@bors
Copy link

bors bot commented Jan 6, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix: add PUnit/PEmpty to additive dict [Merged by Bors] - fix: add PUnit/PEmpty to additive dict Jan 6, 2023
@bors bors bot closed this Jan 6, 2023
@bors bors bot deleted the toAdditivePUnit branch January 6, 2023 02:05
bors bot pushed a commit that referenced this pull request Jan 9, 2023
@fpvandoorn @arienmalec @hrmacbeth
feat: Port algebra.punit_instances (#1319)
39a53f6 
Port of algebra.punit_instances

- [x] depends on: #1330
- [x] depends on: #1314

Co-authored-by: Arien Malec <arien.malec@gmail.com>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Ruben-VandeVelde pushed a commit that referenced this pull request Jan 9, 2023
@fpvandoorn @arienmalec
@hrmacbeth @Ruben-VandeVelde
feat: Port algebra.punit_instances (#1319)
fc69f44 
Port of algebra.punit_instances

- [x] depends on: #1330
- [x] depends on: #1314

Co-authored-by: Arien Malec <arien.malec@gmail.com>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@fpvandoorn @arienmalec
@hrmacbeth @jcommelin
feat: Port algebra.punit_instances (#1319)
65fc2e7 
Port of algebra.punit_instances

- [x] depends on: #1330
- [x] depends on: #1314

Co-authored-by: Arien Malec <arien.malec@gmail.com>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fpvandoorn @gebner