Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Algebra/Lie/Weights): The root system of a lie algebra. #13307

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(Algebra/Lie/Weights): The root system of a lie algebra. #13307

wants to merge 4 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented May 28, 2024

Open in Gitpod

@erdOne erdOne added the WIP Work in progress label May 28, 2024
@erdOne erdOne mentioned this pull request May 28, 2024
Closed
@erdOne erdOne added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) and removed WIP Work in progress labels May 28, 2024
@jcommelin jcommelin linked an issue May 28, 2024 that may be closed by this pull request
The roots of a Lie algebra are a root system. #10064
Closed
jcommelin
jcommelin approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice!

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 28, 2024

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels May 28, 2024
@erdOne
Copy link
Member Author

erdOne commented May 28, 2024

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 28, 2024

👎 Rejected by label

@erdOne
Copy link
Member Author

erdOne commented May 28, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request May 28, 2024
@erdOne
feat(Algebra/Lie/Weights): The root system of a lie algebra. (#13307)
5313885 
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Lie/Weights): The root system of a lie algebra. [Merged by Bors] - feat(Algebra/Lie/Weights): The root system of a lie algebra. May 28, 2024
@mathlib-bors mathlib-bors bot closed this May 28, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/rootSystem branch May 28, 2024 14:16
callesonne pushed a commit that referenced this pull request Jun 4, 2024
@erdOne @callesonne
feat(Algebra/Lie/Weights): The root system of a lie algebra. (#13307)
36841e0 
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
js2357 pushed a commit that referenced this pull request Jun 18, 2024
@erdOne @js2357
feat(Algebra/Lie/Weights): The root system of a lie algebra. (#13307)
2719bc4 
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated t-algebra Algebra (groups, rings, fields etc)
Projects
Classification of semisimple Lie algebras
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The roots of a Lie algebra are a root system.
3 participants
@erdOne @jcommelin @leanprover-community-mathlib4-bot