[Merged by Bors] - feat: port Algebra.Star.Basic #1331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qawbecrdtey
added
WIP
semorrison
added
the
merge-conflict
qawbecrdtey
removed
the
merge-conflict
merge from master
merge from master
Co-authored-by: Johan Commelin <johan@commelin.net>
qawbecrdtey
added
awaiting-review
jcommelin
reviewed
Jan 7, 2023
| --#align star_rat_cast star_rat_cast | ||
| section | ||
| -- Porting note: This takes too long | ||
| set_option maxHeartbeats 0 |
There was a problem hiding this comment.
I have no clue why it needs so much time. But we should investigate this, because the proofs look pretty innocent.
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Ruben-VandeVelde
previously requested changes
Jan 7, 2023
dupuisf
added
awaiting-author
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
qawbecrdtey
added
awaiting-review
qawbecrdtey
dismissed
Ruben-VandeVelde’s stale review
These changs have been applied
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
Co-authored-by: Frédéric Dupuis <dupuisf@iro.umontreal.ca> Co-authored-by: qawbecrdtey <40463813+qawbecrdtey@users.noreply.github.com> Co-authored-by: Siddhartha Gadgil <siddhartha.gadgil@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
jcommelin
pushed a commit
that referenced
this pull request
Jan 23, 2023
Co-authored-by: Frédéric Dupuis <dupuisf@iro.umontreal.ca> Co-authored-by: qawbecrdtey <40463813+qawbecrdtey@users.noreply.github.com> Co-authored-by: Siddhartha Gadgil <siddhartha.gadgil@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.