Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: the non-unital star subalgebra generated by id is dense in C(s, 𝕜)₀ #13326

Closed
wants to merge 4 commits into from

Conversation

j-loreaux
Copy link
Collaborator

@j-loreaux j-loreaux commented May 28, 2024

This is a version of the Weierstrass approximation theorem for C(s, 𝕜)₀, and is necessary for instances of the non-unital continuous functional calculus.

Co-authored by: @ADedecker


Open in Gitpod

@j-loreaux j-loreaux added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters labels May 28, 2024
@j-loreaux j-loreaux requested a review from dupuisf May 28, 2024 22:33
@j-loreaux j-loreaux added the blocked-by-other-PR This PR depends on another PR to Mathlib label May 28, 2024
@j-loreaux j-loreaux changed the base branch from j-loreaux/ContinuousMapZeroMaterial to master May 28, 2024 22:52
Comment on lines +6 to 10
import Mathlib.Algebra.Algebra.Subalgebra.Unitization
import Mathlib.Analysis.RCLike.Basic
import Mathlib.Topology.Algebra.StarSubalgebra
import Mathlib.Topology.ContinuousFunction.ContinuousMapZero
import Mathlib.Topology.ContinuousFunction.Weierstrass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How heavy are these new imports?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ContinuousMapZero file is probably just that file itself. The Unitization file pulls in Unitization and all the non-unital subobject stuff. So that's a bit heavier, but in my mind it's not too bad.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess that's not too bad.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib label May 29, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 29, 2024
@j-loreaux j-loreaux removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 29, 2024
@dupuisf
Copy link
Contributor

dupuisf commented May 29, 2024

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 29, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 29, 2024
…(s, 𝕜)₀` (#13326)

This is a version of the Weierstrass approximation theorem for `C(s, 𝕜)₀`, and is necessary for instances of the non-unital continuous functional calculus.

Co-authored by: @ADedecker

- [ ] depends on: #13323
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 29, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: the non-unital star subalgebra generated by id is dense in C(s, 𝕜)₀ [Merged by Bors] - feat: the non-unital star subalgebra generated by id is dense in C(s, 𝕜)₀ May 29, 2024
@mathlib-bors mathlib-bors bot closed this May 29, 2024
@mathlib-bors mathlib-bors bot deleted the j-loreaux/AdjoinEqSpan branch May 29, 2024 17:17
callesonne pushed a commit that referenced this pull request Jun 4, 2024
…(s, 𝕜)₀` (#13326)

This is a version of the Weierstrass approximation theorem for `C(s, 𝕜)₀`, and is necessary for instances of the non-unital continuous functional calculus.

Co-authored by: @ADedecker

- [ ] depends on: #13323
js2357 pushed a commit that referenced this pull request Jun 18, 2024
…(s, 𝕜)₀` (#13326)

This is a version of the Weierstrass approximation theorem for `C(s, 𝕜)₀`, and is necessary for instances of the non-unital continuous functional calculus.

Co-authored by: @ADedecker

- [ ] depends on: #13323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants