Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: remove some refine' replacing refine_struct #13490

Closed
wants to merge 3 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

@Parcly-Taxel Parcly-Taxel commented Jun 4, 2024

Split from #13385. In these cases the line count either stays the same or decreases. Also remove references to refine_struct.


Open in Gitpod

In these cases the line count either stays the same or decreases.
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR tech debt tracking cross-cutting technical debt labels Jun 4, 2024
@Parcly-Taxel
Copy link
Collaborator Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 3327c22.
There were significant changes against commit ae0be75:

  Benchmark                  Metric         Change
  ================================================
+ ~Mathlib.Data.Real.Basic   instructions   -34.3%

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Mathlib/Algebra/PUnitInstances.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 4, 2024

✌️ Parcly-Taxel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Jun 4, 2024
Co-authored-by: Johan Commelin <johan@commelin.net>
@Parcly-Taxel
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jun 4, 2024
Split from #13385. In these cases the line count either stays the same or decreases. Also remove references to `refine_struct`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove some refine' replacing refine_struct [Merged by Bors] - chore: remove some refine' replacing refine_struct Jun 4, 2024
@mathlib-bors mathlib-bors bot closed this Jun 4, 2024
@mathlib-bors mathlib-bors bot deleted the nrp2 branch June 4, 2024 06:26
callesonne pushed a commit that referenced this pull request Jun 4, 2024
Split from #13385. In these cases the line count either stays the same or decreases. Also remove references to `refine_struct`.
grunweg pushed a commit that referenced this pull request Jun 7, 2024
Split from #13385. In these cases the line count either stays the same or decreases. Also remove references to `refine_struct`.
AntoineChambert-Loir pushed a commit that referenced this pull request Jun 20, 2024
Split from #13385. In these cases the line count either stays the same or decreases. Also remove references to `refine_struct`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated tech debt tracking cross-cutting technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants