[Merged by Bors] - feat: missing API lemmas about the prod instance in Order/CompleteLattice #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrmacbeth
added
the
mathlib3-pair
|
Thanks for doing this, but I think it would be best to wait for mathport to run and discard the manual port in favor of the automatic one. There are some ongoing discussions on Zulip about that. |
alreadydone
changed the title
|
https://github.com/leanprover-community/mathlib3port/blob/master/Mathbin/Order/CompleteLattice.lean should be ready in about 4 hours |
Ruben-VandeVelde
added
the
awaiting-author
eric-wieser
force-pushed
the
mans0954/prod.complete_lattice
branch
from
b248c5c
to
cdee174
Compare
eric-wieser
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
…tice (#1369) This adds lemmas about how `fst`, `snd`, and `swap` interact with `supₛ` and `infₛ`. Manual port of a [mathlib PR](leanprover-community/mathlib#18029) by @eric-wieser Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
|
Whoops, we forgot to update the SHA here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds lemmas about how
fst,snd, andswapinteract withsupₛandinfₛ.Manual port of leanprover-community/mathlib#18029 by @eric-wieser