Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.List.Join #1395

Closed
wants to merge 20 commits into from
Closed

[Merged by Bors] - feat: port Data.List.Join #1395

wants to merge 20 commits into from

Conversation

zeramorphic
Copy link
Collaborator

@zeramorphic zeramorphic commented Jan 7, 2023 •
edited by jcommelin

@zeramorphic zeramorphic added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 7, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jan 7, 2023
@zeramorphic
File compiles
93c09ad 
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic
Fix deprecations
63ddb20 
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic
Naming fixes
7c58142 
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic
Revert BigOperators/Basic.lean to match PR branch
4409f49 
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic
Copy link
Collaborator Author

Following Mario's advice, I modified the proof of eq_iff_join_eq to avoid using nthLe at all. This duplicates a couple of lemmas, so they now have nthLe and get variants. The nthLe variants are marked as deprecated.

@zeramorphic zeramorphic removed the WIP Work in progress label Jan 7, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jan 10, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 10, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 10, 2023
@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Jan 10, 2023
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 10, 2023
@zeramorphic
Align List.isEmpty
0e48dc0 
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic
Copy link
Collaborator Author

zeramorphic commented Jan 10, 2023 •
edited

I think I've put the align in the right place. I'm still not sure about the correct spelling of join_filter_isEmpty_eq_false.

@jcommelin jcommelin added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 10, 2023
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 10, 2023
bors bot pushed a commit that referenced this pull request Jan 10, 2023
@jcommelin @ChrisHughes24 @zeramorphic
feat: port Data.List.Join (#1395)
0c18be9 
- [x] depends on: #1380

Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: thirdsgames <thirdsgames2018@gmail.com>
Co-authored-by: zeramorphic <zeramorphic@proton.me>
@bors
Copy link

bors bot commented Jan 10, 2023

Canceled.

@jcommelin
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Jan 10, 2023
@jcommelin @ChrisHughes24 @zeramorphic
feat: port Data.List.Join (#1395)
07eef42 
- [x] depends on: #1380

Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: thirdsgames <thirdsgames2018@gmail.com>
Co-authored-by: zeramorphic <zeramorphic@proton.me>
@bors
Copy link

bors bot commented Jan 10, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.List.Join [Merged by Bors] - feat: port Data.List.Join Jan 10, 2023
@bors bors bot closed this Jan 10, 2023
@bors bors bot deleted the port/Data.List.Join branch January 10, 2023 12:24
jcommelin added a commit that referenced this pull request Jan 23, 2023
@jcommelin @ChrisHughes24 @zeramorphic
feat: port Data.List.Join (#1395)
61f6e81 
- [x] depends on: #1380

Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: thirdsgames <thirdsgames2018@gmail.com>
Co-authored-by: zeramorphic <zeramorphic@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zeramorphic @semorrison @jcommelin @ChrisHughes24