Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Rat.Floor #1418

Closed
wants to merge 76 commits into from
Closed

[Merged by Bors] - feat: port Data.Rat.Floor #1418

wants to merge 76 commits into from

Conversation

hrmacbeth
Copy link
Member

@hrmacbeth hrmacbeth commented Jan 7, 2023 •
edited

ADedecker and others added 30 commits January 2, 2023 21:51
@hrmacbeth hrmacbeth added the WIP Work in progress label Jan 7, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jan 7, 2023
@hrmacbeth hrmacbeth added mathlib-port This is a port of a theory file from mathlib. and removed WIP Work in progress labels Jan 9, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 10, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jan 10, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 10, 2023
@hrmacbeth hrmacbeth added the awaiting-review The author would like community review of the PR label Jan 10, 2023
jcommelin
jcommelin approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 10, 2023
bors bot pushed a commit that referenced this pull request Jan 10, 2023
@ADedecker @hrmacbeth @Ruben-VandeVelde
feat: port Data.Rat.Floor (#1418)
1d28dad 
- [x] depends on: #1304
- [x] depends on: #1422
- [x] depends on: #1427

Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 10, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Rat.Floor [Merged by Bors] - feat: port Data.Rat.Floor Jan 10, 2023
@bors bors bot closed this Jan 10, 2023
@bors bors bot deleted the Data.Rat.Floor branch January 10, 2023 18:39
@LukasMias LukasMias mentioned this pull request Jan 10, 2023
Closed
1 task
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@ADedecker @hrmacbeth
@Ruben-VandeVelde @jcommelin
feat: port Data.Rat.Floor (#1418)
3e8e412 
- [x] depends on: #1304
- [x] depends on: #1422
- [x] depends on: #1427

Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@hrmacbeth @semorrison @jcommelin @ADedecker @Ruben-VandeVelde @digama0 @LukasMias @gebner