Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Computability.Language #1453

Closed
wants to merge 27 commits into from
Closed

[Merged by Bors] - feat: port Computability.Language #1453

wants to merge 27 commits into from

Conversation

qawbecrdtey
Copy link
Collaborator

@qawbecrdtey qawbecrdtey commented Jan 10, 2023 •
edited by Komyyy
Loading

@qawbecrdtey qawbecrdtey added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 10, 2023
@qawbecrdtey qawbecrdtey added the help-wanted The author needs attention to resolve issues label Jan 10, 2023
@qawbecrdtey qawbecrdtey added awaiting-review and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Jan 11, 2023
jcommelin
jcommelin reviewed Jan 11, 2023
View reviewed changes
Mathlib/Computability/Language.lean Outdated Show resolved Hide resolved
Mathlib/Computability/Language.lean Show resolved Hide resolved
Mathlib/Computability/Language.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jan 11, 2023
@qawbecrdtey qawbecrdtey added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes awaiting-review labels Jan 11, 2023
dupuisf
dupuisf reviewed Jan 12, 2023
View reviewed changes
Mathlib/Computability/Language.lean Outdated Show resolved Hide resolved
Mathlib/Computability/Language.lean Outdated Show resolved Hide resolved
eric-wieser
eric-wieser requested changes Jan 12, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we want to avoid porting this file until leanprover-community/mathlib#17965 is resolved. This is a very much a leaf file, so there's no rush at all to port it.

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 3, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 3, 2023
@eric-wieser eric-wieser added WIP Work in progress blocked-by-other-PR This PR depends on another PR to Mathlib and removed awaiting-review blocked-by-other-PR This PR depends on another PR to Mathlib labels Feb 7, 2023
@Komyyy Komyyy added awaiting-review WIP Work in progress merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed WIP Work in progress awaiting-review labels Feb 15, 2023
@Komyyy Komyyy added awaiting-review and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. WIP Work in progress labels Feb 15, 2023
dupuisf
dupuisf reviewed Feb 15, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Feb 15, 2023
bors bot pushed a commit that referenced this pull request Feb 15, 2023
@qawbecrdtey @Komyyy
feat: port Computability.Language (#1453)
87a53f8 
Co-authored-by: qawbecrdtey <40463813+qawbecrdtey@users.noreply.github.com>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
@bors
Copy link

bors bot commented Feb 15, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Computability.Language [Merged by Bors] - feat: port Computability.Language Feb 15, 2023
@bors bors bot closed this Feb 15, 2023
@bors bors bot deleted the port/Computability.Language branch February 15, 2023 15:02
mo271 pushed a commit that referenced this pull request Feb 18, 2023
@qawbecrdtey @Komyyy @mo271
feat: port Computability.Language (#1453)
e4b6069 
Co-authored-by: qawbecrdtey <40463813+qawbecrdtey@users.noreply.github.com>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser requested changes

@jcommelin jcommelin jcommelin left review comments

@dupuisf dupuisf dupuisf left review comments

@Komyyy Komyyy Komyyy left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@qawbecrdtey @semorrison @eric-wieser @jcommelin @dupuisf @Komyyy