-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(PULL_REQUEST_TEMPLATE.md): add template for moves and deletions #14559
Conversation
jcommelin
commented
Jul 9, 2024
PR summary 3d0ea229c3Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Is the intention that a bot will fill this in? |
Maybe not directly filling in, but certainly the intention is that a bot will generate a first draft that can be copy-pasta-edited. |
In particular, the pairs of declarations that |
Co-authored-by: damiano <adomani@gmail.com>
I looked briefly into this and I am only seeing hacky ways of getting a PR template that depends on the PR itself. As far as I understand, GitHub simply reads the file that this PR is editing and uses that as a template. So, this file would have had to be edited between pushing and creating a PR. For instance, the very first action upon pushing could be to compute the decl_diff, modify the PR_template file and then have it ready by the time you actually open the PR! I wonder if not git-indexing this file and simply regenerating it on every push would give the "personalised touch" that we want. |
I think if we develop a bot that can contribute answers here, it should just run after the PR is open. We can add a note to the template saying "You don't need to fill this in immediately: a bot will edit the PR top comment shortly with a first approximation, and you should check that it looks right." |
bors merge |
Build failed (retrying...): |
Pull request successfully merged into master. Build succeeded: |