Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: use modern ubuntu version for gitpod #1457

Closed
wants to merge 6 commits into from

Conversation

gebner
Copy link
Member

@gebner gebner commented Jan 10, 2023

This fixes lake exe cache get in gitpod.


Open in Gitpod

@eric-wieser
Copy link
Member

We might need to copy some stuff from https://github.com/gitpod-io/workspace-images/blob/main/base/Dockerfile if we update the image.

@eric-wieser
Copy link
Member

@gebner
Copy link
Member Author

gebner commented Jan 10, 2023

It's probably worth installing the latest git version, since the default image does

I don't think that's enough of a reason. I would only add the extra PPA if you want a git feature from git > 2.34. (Upgrading git makes a lot more sense for ancient ubuntu versions which have a correspondingly ancient git version.)

@gebner
Copy link
Member Author

gebner commented Jan 10, 2023

I've added all the other goodies you've pointed out.

@gebner
Copy link
Member Author

gebner commented Jan 10, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 10, 2023
bors bot pushed a commit that referenced this pull request Jan 10, 2023
This fixes `lake exe cache get` in gitpod.
@bors
Copy link

bors bot commented Jan 10, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix: use modern ubuntu version for gitpod [Merged by Bors] - fix: use modern ubuntu version for gitpod Jan 10, 2023
@bors bors bot closed this Jan 10, 2023
@bors bors bot deleted the fixgitpod branch January 10, 2023 23:58
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
This fixes `lake exe cache get` in gitpod.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants