Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: Move smooth_barycentric_coord #14666

Closed
wants to merge 1 commit into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Jul 12, 2024

Moving it to a new file Analysis.Calculus.AddTorsor.Coord significantly reduces the imports to Analysis.NormedSpace.AddTorsorBases. Also rename Analysis.Calculus.AffineMap to Analysis.Calculus.AddTorsor.AffineMap.


Open in Gitpod

Moving it to a new file `Analysis.Calculus.AddTorsor.Coord` significantly reduces the imports to `Analysis.NormedSpace.AddTorsorBases`.

Move
* `Analysis.Calculus.AffineMap` to `Analysis.Calculus.AddTorsor.AffineMap`
@YaelDillies YaelDillies added t-analysis Analysis (normed *, calculus) t-euclidean-geometry Affine and axiomatic geometry labels Jul 12, 2024
Copy link

PR summary 6feb86efce

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Analysis.NormedSpace.AddTorsorBases 1496 1461 -35 (-2.34%)
Import changes for all files
Files Import difference
Mathlib.Analysis.Calculus.AffineMap -1305
Mathlib.Analysis.Convex.Intrinsic Mathlib.Analysis.NormedSpace.AddTorsorBases -35
Mathlib.MeasureTheory.Group.GeometryOfNumbers Mathlib.Analysis.Convex.Measure -21
10 files Mathlib.NumberTheory.Cyclotomic.Rat Mathlib.NumberTheory.Cyclotomic.Discriminant Mathlib.NumberTheory.NumberField.Discriminant Mathlib.NumberTheory.Cyclotomic.Three Mathlib.NumberTheory.FLT.Three Mathlib.NumberTheory.NumberField.CanonicalEmbedding.ConvexBody Mathlib.NumberTheory.Cyclotomic.PID Mathlib.NumberTheory.NumberField.Units.DirichletTheorem Mathlib.NumberTheory.NumberField.Units.Regulator Mathlib.NumberTheory.NumberField.ClassNumber
-3
Mathlib.Analysis.Calculus.AddTorsor.AffineMap 1305
Mathlib.Analysis.Calculus.AddTorsor.Coord 1497

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@urkud
Copy link
Member

urkud commented Jul 12, 2024

Thanks! 🎉
bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 12, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 12, 2024
Moving it to a new file `Analysis.Calculus.AddTorsor.Coord` significantly reduces the imports to `Analysis.NormedSpace.AddTorsorBases`. Also rename `Analysis.Calculus.AffineMap` to `Analysis.Calculus.AddTorsor.AffineMap`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 12, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Move smooth_barycentric_coord [Merged by Bors] - chore: Move smooth_barycentric_coord Jul 12, 2024
@mathlib-bors mathlib-bors bot closed this Jul 12, 2024
@mathlib-bors mathlib-bors bot deleted the split_smooth_barycentric_coord branch July 12, 2024 07:05
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus) t-euclidean-geometry Affine and axiomatic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants