Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Data.Multiset.Basic #1491

Closed
wants to merge 30 commits into from

Conversation

jcommelin
Copy link
Member


Open in Gitpod

@hrmacbeth hrmacbeth added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 11, 2023
Mathlib.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Basic.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 13, 2023
Mathlib/Data/Multiset/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Basic.lean Outdated Show resolved Hide resolved
decreasing_by exact card_lt_of_lt _h
#align multiset.strong_induction_on Multiset.strongInductionOnₓ -- Porting note: reorderd universes

theorem strong_induction_eq {p : Multiset α → Sort _} (s : Multiset α) (H) :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should this be called? Maybe strongInductionOn_eq would make more sense

end

@[ext]
theorem add_hom_ext [AddZeroClass β] ⦃f g : Multiset α →+ β⦄ (h : ∀ x, f {x} = g {x}) : f = g :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addHom_ext?

Mathlib/Data/Multiset/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Basic.lean Outdated Show resolved Hide resolved
jcommelin and others added 4 commits January 13, 2023 09:15
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 13, 2023
bors bot pushed a commit that referenced this pull request Jan 13, 2023
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Reid Barton <rwbarton@gmail.com>
Co-authored-by: qawbecrdtey <qawbecrdtey@kaist.ac.kr>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 13, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Multiset.Basic [Merged by Bors] - feat: port Data.Multiset.Basic Jan 13, 2023
@bors bors bot closed this Jan 13, 2023
@bors bors bot deleted the port/Data.Multiset.Basic branch January 13, 2023 10:05
jcommelin added a commit that referenced this pull request Jan 23, 2023
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Reid Barton <rwbarton@gmail.com>
Co-authored-by: qawbecrdtey <qawbecrdtey@kaist.ac.kr>
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants