Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.List.Sublists #1494

Closed
wants to merge 26 commits into from
Closed

[Merged by Bors] - feat: port Data.List.Sublists #1494

wants to merge 26 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added mathlib-port This is a port of a theory file from mathlib. help-wanted The author needs attention to resolve issues labels Jan 11, 2023
@qawbecrdtey
Copy link
Collaborator

sublistsAux seems to be removed, and sublistsAux₁ also is the subject to be removed. I believe theorems related to those two in the statement should be removed, or note that it will be removed. I'll ask in Zulip.

@qawbecrdtey
Copy link
Collaborator

Or sublistsAux₁ should not be removed, but should be moved to Sublists.lean. I'll give a commit about that.

@qawbecrdtey qawbecrdtey added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Jan 13, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 13, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 13, 2023
jcommelin
jcommelin approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 13, 2023
bors bot pushed a commit that referenced this pull request Jan 13, 2023
@Ruben-VandeVelde @qawbecrdtey @ChrisHughes24
feat: port Data.List.Sublists (#1494)
fb6c6c4 
Co-authored-by: qawbecrdtey <qawbecrdtey@kaist.ac.kr>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented Jan 13, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.List.Sublists [Merged by Bors] - feat: port Data.List.Sublists Jan 13, 2023
@bors bors bot closed this Jan 13, 2023
@bors bors bot deleted the port/Data.List.Sublists branch January 13, 2023 10:53
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@Ruben-VandeVelde @qawbecrdtey
@ChrisHughes24 @jcommelin
feat: port Data.List.Sublists (#1494)
c378d36 
Co-authored-by: qawbecrdtey <qawbecrdtey@kaist.ac.kr>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ruben-VandeVelde @qawbecrdtey @jcommelin @semorrison @ChrisHughes24