Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: forward port leanprover-community/mathlib#18121 #1497

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 11, 2023

@eric-wieser eric-wieser added mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged awaiting-review The author would like community review of the PR labels Jan 11, 2023
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

In the mathilib3 PR you also modified some proofs (for example lift_comp_of). Is it possible to do the same here?

@riccardobrasca
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Jan 12, 2023

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Jan 12, 2023
@eric-wieser
Copy link
Member Author

Good catch, fixed.

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 12, 2023
bors bot pushed a commit that referenced this pull request Jan 12, 2023
@bors
Copy link

bors bot commented Jan 12, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: forward port leanprover-community/mathlib#18121 [Merged by Bors] - feat: forward port leanprover-community/mathlib#18121 Jan 12, 2023
@bors bors bot closed this Jan 12, 2023
@bors bors bot deleted the eric-wieser/forward-port-18121 branch January 12, 2023 12:21
eric-wieser added a commit that referenced this pull request Feb 3, 2023
bors bot pushed a commit that referenced this pull request Mar 19, 2023
bors bot pushed a commit that referenced this pull request Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants