-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: forward port leanprover-community/mathlib#18121 #1497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
In the mathilib3 PR you also modified some proofs (for example lift_comp_of
). Is it possible to do the same here?
bors d+ |
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Good catch, fixed. bors merge |
Pull request successfully merged into master. Build succeeded: |
Comparing https://leanprover-community.github.io/mathlib-port-status/out-of-sync against #1497 shows that this is already up to date.
Comparing https://leanprover-community.github.io/mathlib-port-status/file/algebra/free_monoid/basic against #1497 shows that this is already up to date.
Comparing https://leanprover-community.github.io/mathlib-port-status/file/algebra/free_monoid/basic against #1497 shows that this is already up to date.
leanprover-community/mathlib#18121