Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Fin.Tuple.Basic #1516

Closed
wants to merge 25 commits into from
Closed

[Merged by Bors] - feat: port Data.Fin.Tuple.Basic #1516

wants to merge 25 commits into from

Conversation

maxwell-thum
Copy link
Collaborator

@maxwell-thum maxwell-thum commented Jan 12, 2023 •
edited by jcommelin
Loading

@maxwell-thum maxwell-thum added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 12, 2023
@maxwell-thum maxwell-thum added the help-wanted The author needs attention to resolve issues label Jan 13, 2023
@jcommelin
Copy link
Member

Why is there "attempt 2" in the PR title? It shouldn't stay there when we merge this.

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 13, 2023
@eric-wieser
Copy link
Member

eric-wieser commented Jan 13, 2023 •
edited by Ruben-VandeVelde
Loading

Reiterating the message from the porting wiki, I would prefer that we get leanprover-community/mathlib#10346 in first, as this change the file and the things it depends on a fair bit.

eric-wieser
eric-wieser reviewed Jan 13, 2023
View reviewed changes
Mathlib/Data/Fin/Tuple/Basic.lean
Comment on lines +69 to +72
-- Porting note: I made this noncomputable because Lean seemed to think it should be
/-- Adding an element at the beginning of an `n`-tuple, to get an `n+1`-tuple. -/
noncomputable def cons (x : α 0) (p : ∀ i : Fin n, α i.succ) : ∀ i, α i := fun j ↦ Fin.cases x p j
#align fin.cons Fin.cons
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a lean issue tracking this? It seems bizarre that SomeInductive.cases is noncomputable when the equation compiler is happy to produce something computable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compiler ignores the actual Lean term generated by pattern matching and just compiles the pattern matching directly. I'm sure it's on the todo list of the developers.

@maxwell-thum
Copy link
Collaborator Author

Why is there "attempt 2" in the PR title? It shouldn't stay there when we merge this.

When I first tried porting this (#1515) I got a strange error where ToAdditive.lean wouldn't build. I couldn't understand why (and I'm not super familiar with GitHub), so I deleted the branch and started over, running start_port.sh by hand. I'll change the PR titles.

@maxwell-thum maxwell-thum changed the title feat: port Data.Fin.Tuple.Basic (attempt 2) feat: port Data.Fin.Tuple.Basic Jan 13, 2023
@maxwell-thum
Copy link
Collaborator Author

Reiterating the message from the porting wiki, I would prefer that we get #10346 in first, as this change the file and the things it depends on a fair bit.

My bad; I didn't see that message.

@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 17, 2023
Ruben-VandeVelde
Ruben-VandeVelde requested changes Jan 17, 2023
View reviewed changes
Mathlib/Data/Fin/Tuple/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Fin/Tuple/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Fin/Tuple/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Fin/Tuple/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Fin/Tuple/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Fin/Tuple/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Fin/Tuple/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Fin/Tuple/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Fin/Tuple/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Fin/Tuple/Basic.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Jan 17, 2023
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Jan 17, 2023
View reviewed changes
Mathlib/Data/Fin/Tuple/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Fin/Tuple/Basic.lean Outdated Show resolved Hide resolved
@Ruben-VandeVelde
Copy link
Collaborator

Reiterating the message from the porting wiki, I would prefer that we get leanprover-community/mathlib#10346 in first, as this change the file and the things it depends on a fair bit.

For the record, we discussed this on zulip and ended up not waiting for this, because mathlib3port is not being updated right now. I'm happy to help re-port once it's back up (though you may need to remind me).

@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 17, 2023
bors bot pushed a commit that referenced this pull request Jan 17, 2023
@maxwell-thum @qawbecrdtey
@jcommelin @Ruben-VandeVelde
feat: port Data.Fin.Tuple.Basic (#1516)
a43b3f1 
Co-authored-by: qawbecrdtey <40463813+qawbecrdtey@users.noreply.github.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 17, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Fin.Tuple.Basic [Merged by Bors] - feat: port Data.Fin.Tuple.Basic Jan 17, 2023
@bors bors bot closed this Jan 17, 2023
@bors bors bot deleted the port/Data.Fin.Tuple.Basic branch January 17, 2023 13:46
jcommelin added a commit that referenced this pull request Jan 23, 2023
@maxwell-thum @qawbecrdtey
@jcommelin @Ruben-VandeVelde
feat: port Data.Fin.Tuple.Basic (#1516)
e0ddfdc 
Co-authored-by: qawbecrdtey <40463813+qawbecrdtey@users.noreply.github.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin left review comments

@ChrisHughes24 ChrisHughes24 ChrisHughes24 left review comments

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@maxwell-thum @jcommelin @eric-wieser @Ruben-VandeVelde @ChrisHughes24 @semorrison @qawbecrdtey