Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Logic.Encodable.Basic #1517

Closed
wants to merge 47 commits into from
Closed

[Merged by Bors] - feat: port Logic.Encodable.Basic #1517

wants to merge 47 commits into from

Conversation

arienmalec
Copy link
Collaborator

Port of logic.encodable.basic

Open in Gitpod

@arienmalec arienmalec added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 13, 2023
@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes label Jan 13, 2023
ChrisHughes24 and others added 2 commits January 13, 2023 14:42
@ChrisHughes24 @jcommelin
Update Mathlib/Logic/Encodable/Basic.lean
56faef7 
Co-authored-by: Johan Commelin <johan@commelin.net>
@ChrisHughes24 @jcommelin
Update Mathlib/Logic/Encodable/Basic.lean
ccf183f 
Co-authored-by: Johan Commelin <johan@commelin.net>
@arienmalec arienmalec added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 13, 2023
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 13, 2023
@arienmalec @jcommelin
Update Mathlib/Logic/Encodable/Basic.lean
5acdd3e 
Co-authored-by: Johan Commelin <johan@commelin.net>
@arienmalec arienmalec added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 13, 2023
@jcommelin
Copy link
Member

lint is failing

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 13, 2023
@arienmalec
Copy link
Collaborator Author

lint is failing

Posted to Zulip.

@arienmalec arienmalec added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 14, 2023
jcommelin
jcommelin approved these changes Jan 14, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 14, 2023
bors bot pushed a commit that referenced this pull request Jan 14, 2023
@arienmalec
feat: port Logic.Encodable.Basic (#1517)
ea3b08c 
Port of logic.encodable.basic
@bors
Copy link

bors bot commented Jan 14, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Logic.Encodable.Basic [Merged by Bors] - feat: port Logic.Encodable.Basic Jan 14, 2023
@bors bors bot closed this Jan 14, 2023
@bors bors bot deleted the port/Logic.Encodable.Basic branch January 14, 2023 04:11
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@arienmalec @jcommelin
feat: port Logic.Encodable.Basic (#1517)
ac4c9ee 
Port of logic.encodable.basic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arienmalec @jcommelin @semorrison @ChrisHughes24