Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.Order.Pointwise #1533

Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - feat: port Algebra.Order.Pointwise #1533

wants to merge 14 commits into from

Conversation

qawbecrdtey
Copy link
Collaborator

Open in Gitpod

@qawbecrdtey qawbecrdtey added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 13, 2023
@qawbecrdtey qawbecrdtey added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 13, 2023
@qawbecrdtey qawbecrdtey changed the title port Algebra.Order.Pointwise feat: port Algebra.Order.Pointwise Jan 13, 2023
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 13, 2023
@qawbecrdtey qawbecrdtey added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 13, 2023
jcommelin
jcommelin reviewed Jan 13, 2023
View reviewed changes
Mathlib/Algebra/Order/Pointwise.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Order/Pointwise.lean Outdated Show resolved Hide resolved
@ChrisHughes24 ChrisHughes24 added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 13, 2023
@qawbecrdtey qawbecrdtey added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 13, 2023
jcommelin
jcommelin reviewed Jan 13, 2023
View reviewed changes
Mathlib/Algebra/Order/Pointwise.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Order/Pointwise.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Order/Pointwise.lean Outdated Show resolved Hide resolved
@jcommelin
Copy link
Member

There is still a new import... if we need it, please explain why.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 13, 2023
@qawbecrdtey qawbecrdtey added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 13, 2023
jcommelin
jcommelin approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 13, 2023
bors bot pushed a commit that referenced this pull request Jan 13, 2023
@qawbecrdtey
feat: port Algebra.Order.Pointwise (#1533)
930a6c1 
Co-authored-by: qawbecrdtey <qawbecrdtey@naver.com>
@bors
Copy link

bors bot commented Jan 13, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.Order.Pointwise [Merged by Bors] - feat: port Algebra.Order.Pointwise Jan 13, 2023
@bors bors bot closed this Jan 13, 2023
@bors bors bot deleted the port/Algebra.Order.Pointwise branch January 13, 2023 19:02
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@qawbecrdtey @jcommelin
feat: port Algebra.Order.Pointwise (#1533)
b23f8b1 
Co-authored-by: qawbecrdtey <qawbecrdtey@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@qawbecrdtey @jcommelin @eric-wieser @semorrison @ChrisHughes24