[Merged by Bors] - feat: Port Data.Set.Semiring #1535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
riccardobrasca
commented
Jan 13, 2023
riccardobrasca
commented
riccardobrasca
added
mathlib-port
riccardobrasca
commented
Jan 13, 2023
| instance [MulOneClass α] : NonAssocSemiring (SetSemiring α) := | ||
| { (inferInstance : NonUnitalNonAssocSemiring (SetSemiring α)), | ||
| Set.mulOneClass with | ||
| one := Set.up ({1} : Set α) |
There was a problem hiding this comment.
Originally this was one := 1, but it doesn't work with
failed to synthesize instance
OfNat (SetSemiring α) 1
riccardobrasca
added
awaiting-review
|
bors r+ |
github-actions
bot
added
ready-to-merge
jcommelin
reviewed
Jan 13, 2023
| @@ -25,120 +25,143 @@ open Pointwise | |||
|
|
|||
| variable {α β : Type _} | |||
|
|
|||
| -- Porting note: mathlib3 uses `deriving Inhabited, PartialOrder, OrderBot` | |||
| /-- An alias for `set α`, which has a semiring structure given by `∪` as "addition" and pointwise | |||
There was a problem hiding this comment.
Suggested change
| /-- An alias for `set α`, which has a semiring structure given by `∪` as "addition" and pointwise | |
| /-- An alias for `Set α`, which has a semiring structure given by `∪` as "addition" and pointwise |
There was a problem hiding this comment.
This is already done.. maybe you were having a look to an old commit.
|
bors r- |
|
Canceled. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 13, 2023
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
jcommelin
pushed a commit
that referenced
this pull request
Jan 23, 2023
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.