Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Multiset.Nodup #1539

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat: port Data.Multiset.Nodup #1539

wants to merge 12 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde commented Jan 13, 2023 •
edited by eric-wieser

@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Jan 13, 2023
jcommelin
jcommelin reviewed Jan 13, 2023
View reviewed changes
Mathlib/Data/Multiset/Nodup.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Nodup.lean Outdated Show resolved Hide resolved
Ruben-VandeVelde and others added 2 commits January 13, 2023 15:13
@Ruben-VandeVelde @jcommelin
Update Mathlib/Data/Multiset/Bind.lean
91d653b 
Co-authored-by: Johan Commelin <johan@commelin.net>
@Ruben-VandeVelde
Merge remote-tracking branch 'origin/port/Data.Multiset.Bind' into po…
08bee30 
…rt/Data.Multiset.Nodup
@semorrison
Copy link
Contributor

This PR/issue depends on:

@Ruben-VandeVelde @jcommelin
Apply suggestions from code review
71144ea 
Co-authored-by: Johan Commelin <johan@commelin.net>
@Ruben-VandeVelde Ruben-VandeVelde mentioned this pull request Jan 13, 2023
Closed
1 task
jcommelin
jcommelin approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 13, 2023
bors bot pushed a commit that referenced this pull request Jan 13, 2023
@Ruben-VandeVelde
feat: port Data.Multiset.Nodup (#1539)
43502ce
@bors
Copy link

bors bot commented Jan 13, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Multiset.Nodup [Merged by Bors] - feat: port Data.Multiset.Nodup Jan 13, 2023
@bors bors bot closed this Jan 13, 2023
@bors bors bot deleted the port/Data.Multiset.Nodup branch January 13, 2023 14:39
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@Ruben-VandeVelde @jcommelin
feat: port Data.Multiset.Nodup (#1539)
074ce99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ruben-VandeVelde @semorrison @jcommelin