Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Multiset.FinsetOps #1547

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Data.Multiset.FinsetOps #1547

wants to merge 7 commits into from

Conversation

ChrisHughes24
Copy link
Member

Open in Gitpod

@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Jan 13, 2023
jcommelin
jcommelin reviewed Jan 13, 2023
View reviewed changes
Mathlib/Data/Multiset/FinsetOps.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/FinsetOps.lean Outdated Show resolved Hide resolved
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 13, 2023
jcommelin
jcommelin approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@jcommelin jcommelin removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 13, 2023
@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 13, 2023
@jcommelin
Copy link
Member

bors r+

@bors
Copy link

bors bot commented Jan 13, 2023

Already running a review

bors bot pushed a commit that referenced this pull request Jan 13, 2023
@ChrisHughes24 @jcommelin
feat: port Data.Multiset.FinsetOps (#1547)
e609eeb 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jan 13, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Multiset.FinsetOps [Merged by Bors] - feat: port Data.Multiset.FinsetOps Jan 13, 2023
@bors bors bot closed this Jan 13, 2023
@bors bors bot deleted the port/Data.Multiset.FinsetOps branch January 13, 2023 18:55
jcommelin added a commit that referenced this pull request Jan 23, 2023
@ChrisHughes24 @jcommelin
feat: port Data.Multiset.FinsetOps (#1547)
81258fd 
Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChrisHughes24 @jcommelin @semorrison