Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Multiset.Lattice #1556

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Data.Multiset.Lattice #1556

wants to merge 7 commits into from

Conversation

4e554c4c
Copy link
Collaborator

Open in Gitpod

@4e554c4c 4e554c4c added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 13, 2023
@4e554c4c 4e554c4c changed the title Port/data.multiset.lattice feat: port Data.Multiset.Lattice Jan 13, 2023
@4e554c4c 4e554c4c added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 13, 2023
jcommelin
jcommelin reviewed Jan 13, 2023
View reviewed changes
Mathlib/Data/Multiset/Lattice.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Lattice.lean Outdated Show resolved Hide resolved
Mathlib/Data/Multiset/Lattice.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 13, 2023
@4e554c4c 4e554c4c added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 13, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 13, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 13, 2023
jcommelin
jcommelin approved these changes Jan 14, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 14, 2023
bors bot pushed a commit that referenced this pull request Jan 14, 2023
@4e554c4c
feat: port Data.Multiset.Lattice (#1556)
3d0594f 
Co-authored-by: Calvin Lee <calvins.lee@utah.edu>
@bors
Copy link

bors bot commented Jan 14, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Multiset.Lattice [Merged by Bors] - feat: port Data.Multiset.Lattice Jan 14, 2023
@bors bors bot closed this Jan 14, 2023
@bors bors bot deleted the port/Data.Multiset.Lattice branch January 14, 2023 04:16
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@4e554c4c @jcommelin
feat: port Data.Multiset.Lattice (#1556)
d516ead 
Co-authored-by: Calvin Lee <calvins.lee@utah.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@4e554c4c @jcommelin @semorrison