Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.Module.PointwisePi #1557

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: port Algebra.Module.PointwisePi #1557

wants to merge 4 commits into from

Conversation

maxwell-thum
Copy link
Collaborator

Open in Gitpod

@maxwell-thum maxwell-thum added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 13, 2023
@maxwell-thum
Copy link
Collaborator Author

This goes back to (at least) Mathlib.Data.Set.Pointwise.SMul, but shouldn't theorem names involving SMul use the lowerCamelCase sMul instead of smul? (see https://github.com/leanprover-community/mathlib4/wiki/Porting-wiki#naming-convention)

@maxwell-thum maxwell-thum added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 13, 2023
jcommelin
jcommelin approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@maxwell-thum maxwell-thum added the easy < 20s of review time. See the lifecycle page for guidelines. label Jan 13, 2023
@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 13, 2023
bors bot pushed a commit that referenced this pull request Jan 13, 2023
@maxwell-thum
feat: port Algebra.Module.PointwisePi (#1557)
2242310
@maxwell-thum maxwell-thum removed the easy < 20s of review time. See the lifecycle page for guidelines. label Jan 13, 2023
@bors
Copy link

bors bot commented Jan 13, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.Module.PointwisePi [Merged by Bors] - feat: port Algebra.Module.PointwisePi Jan 13, 2023
@bors bors bot closed this Jan 13, 2023
@bors bors bot deleted the port/Algebra.Module.PointwisePi branch January 13, 2023 21:59
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@maxwell-thum @jcommelin
feat: port Algebra.Module.PointwisePi (#1557)
41236b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxwell-thum @jcommelin @semorrison