Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port GroupTheory.GroupAction.Support #1560

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port GroupTheory.GroupAction.Support #1560

wants to merge 5 commits into from

Conversation

maxwell-thum
Copy link
Collaborator

Open in Gitpod

@maxwell-thum maxwell-thum added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 13, 2023
@maxwell-thum maxwell-thum added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. and removed WIP Work in progress labels Jan 13, 2023
jcommelin
jcommelin reviewed Jan 14, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Mathlib/GroupTheory/GroupAction/Support.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 14, 2023

✌️ maxwell-thum can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jan 14, 2023
@maxwell-thum @jcommelin
Update Mathlib/GroupTheory/GroupAction/Support.lean
36a2ac3 
Co-authored-by: Johan Commelin <johan@commelin.net>
@maxwell-thum
Copy link
Collaborator Author

✌️ maxwell-thum can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

bors r+

bors bot pushed a commit that referenced this pull request Jan 14, 2023
@maxwell-thum
feat: port GroupTheory.GroupAction.Support (#1560)
ef7866b 
Co-authored-by: maxwell-thum <119913396+maxwell-thum@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 14, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port GroupTheory.GroupAction.Support [Merged by Bors] - feat: port GroupTheory.GroupAction.Support Jan 14, 2023
@bors bors bot closed this Jan 14, 2023
@bors bors bot deleted the port/GroupTheory.GroupAction.Support branch January 14, 2023 04:30
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@maxwell-thum @jcommelin
feat: port GroupTheory.GroupAction.Support (#1560)
0e35039 
Co-authored-by: maxwell-thum <119913396+maxwell-thum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxwell-thum @jcommelin @semorrison