[Merged by Bors] - feat: port Algebra.Module.LinearMap #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vierkantor
commented
Jan 17, 2023
Comment on lines
+223
to
+225
| -- Porting note: adding this instance prevents a timeout in `ext_ring_op` | ||
| instance {σ : R →+* S} : FunLike (M →ₛₗ[σ] M₃) M (λ _ ↦ M₃) := | ||
| { AddHomClass.toFunLike with } |
There was a problem hiding this comment.
This instance could be removed if we can speed up ext_ring_op in some other way.
There was a problem hiding this comment.
(Indeed, with Gabriel's changes to Lean this can be deleted again.)
Vierkantor
commented
Jan 17, 2023
Comment on lines
+498
to
+499
| -- *TODO*: why are you still timing out? | ||
| set_option maxHeartbeats 300000 in |
There was a problem hiding this comment.
I don't know how to solve this timeout.
Comment on lines
+1085
to
+1086
| -- *TODO*: why are you still timing out? | ||
| set_option maxHeartbeats 300000 in |
There was a problem hiding this comment.
I don't know how to solve this timeout.
|
leanprover/lean4#2003 solves both of the timeouts, so do we want to invest effort in fixing this ourselves? |
jcommelin
reviewed
Jan 20, 2023
jcommelin
added
awaiting-author
Co-authored-by: Johan Commelin <johan@commelin.net>
Vierkantor
added
awaiting-review
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
Zulip thread: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/algebra.2Emodule.2Elinear_map.20mathlib4.231587 Co-authored-by: Vierkantor <vierkantor@vierkantor.com> Co-authored-by: qawbecrdtey <qawbecrdtey@naver.com> Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zulip thread: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/algebra.2Emodule.2Elinear_map.20mathlib4.231587