[Merged by Bors] - chore: remove set_option autoImplicit false
#1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericrbg
added
the
awaiting-review
ericrbg
commented
Jan 16, 2023
| @@ -212,8 +212,6 @@ protected theorem id_map : ∀ x : Comp F G α, Comp.map id x = x | |||
| -- porting note: `rfl` wasn't needed in mathlib3 | |||
| #align functor.comp.id_map Functor.Comp.id_map | |||
|
|
|||
| -- porting note: because `LawfulFunctor G` wasn't needed in the proof we need `autoImplicit`s off | |||
| set_option autoImplicit false in | |||
There was a problem hiding this comment.
@j-loreaux do you remember why this was needed? it seems to compile but I don't want to acci-break something
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 17, 2023
These were mostly added in the process of porting and weren't removed at the end. There was one that may have been needed, let's see what CI says.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
set_option autoImplicit falseset_option autoImplicit false
jcommelin
pushed a commit
that referenced
this pull request
Jan 23, 2023
These were mostly added in the process of porting and weren't removed at the end. There was one that may have been needed, let's see what CI says.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were mostly added in the process of porting and weren't removed at the end. There was one that may have been needed, let's see what CI says.