Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: Data.Finset.Basic Change statement of two simp lemmas so they can be used with rw #1615

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix: Data.Finset.Basic Change statement of two simp lemmas so they can be used with rw #1615

wants to merge 1 commit into from

Conversation

ChrisHughes24
Copy link
Member

Open in Gitpod

@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Jan 17, 2023
jcommelin
jcommelin approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 17, 2023
bors bot pushed a commit that referenced this pull request Jan 17, 2023
@ChrisHughes24
fix: Data.Finset.Basic Change statement of two simp lemmas so they ca…
f768b2c 
…n be used with rw (#1615)
@bors
Copy link

bors bot commented Jan 17, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix: Data.Finset.Basic Change statement of two simp lemmas so they can be used with rw [Merged by Bors] - fix: Data.Finset.Basic Change statement of two simp lemmas so they can be used with rw Jan 17, 2023
@bors bors bot closed this Jan 17, 2023
@bors bors bot deleted the fix-sup_eq_union branch January 17, 2023 08:44
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@ChrisHughes24 @jcommelin
fix: Data.Finset.Basic Change statement of two simp lemmas so they ca…
ed7f5c5 
…n be used with rw (#1615)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChrisHughes24 @jcommelin @semorrison