Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Real.Sign #1618

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port Data.Real.Sign #1618

wants to merge 6 commits into from

Conversation

qawbecrdtey
Copy link
Collaborator

Open in Gitpod

@qawbecrdtey qawbecrdtey added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 17, 2023
@qawbecrdtey qawbecrdtey added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 17, 2023
jcommelin
jcommelin approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 17, 2023
@ChrisHughes24
Copy link
Member

bors r+

@bors
Copy link

bors bot commented Jan 17, 2023

Already running a review

bors bot pushed a commit that referenced this pull request Jan 17, 2023
@qawbecrdtey
feat: port Data.Real.Sign (#1618)
86d0135
@bors
Copy link

bors bot commented Jan 17, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Real.Sign [Merged by Bors] - feat: port Data.Real.Sign Jan 17, 2023
@bors bors bot closed this Jan 17, 2023
@bors bors bot deleted the port/Data.Real.Sign branch January 17, 2023 10:45
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@qawbecrdtey @jcommelin
feat: port Data.Real.Sign (#1618)
7cf91e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qawbecrdtey @ChrisHughes24 @jcommelin @semorrison