Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Control.Functor.Multivariate #1638

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat: port Control.Functor.Multivariate #1638

wants to merge 11 commits into from

Conversation

alexkeizer
Copy link
Collaborator

Open in Gitpod

@alexkeizer alexkeizer added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 18, 2023
@alexkeizer
Copy link
Collaborator Author

During porting I noticed some inconsistent naming in TypeVec (relLast'/predLast' should be RelLast'/PredLast').
Since TypeVec was only merged yesterday, I'm relatively certain no other PR's depend on it yet and I figured I'd fix that naming in this PR as well.
If it's better to do that separately, I can undo that last commit!

@alexkeizer alexkeizer added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 18, 2023
@alexkeizer alexkeizer marked this pull request as ready for review January 18, 2023 12:06
@rwbarton
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 24, 2023
bors bot pushed a commit that referenced this pull request Jan 24, 2023
@alexkeizer @rwbarton
feat: port Control.Functor.Multivariate (#1638)
38c9db9 
Co-authored-by: Reid Barton <rwbarton@gmail.com>
@bors
Copy link

bors bot commented Jan 24, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Control.Functor.Multivariate [Merged by Bors] - feat: port Control.Functor.Multivariate Jan 24, 2023
@bors bors bot closed this Jan 24, 2023
@bors bors bot deleted the alexkeizer/data.functor.multivariate branch January 24, 2023 19:53
alexkeizer added a commit that referenced this pull request Jan 25, 2023
@alexkeizer @rwbarton
feat: port Control.Functor.Multivariate (#1638)
01bdf2a 
Co-authored-by: Reid Barton <rwbarton@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexkeizer @rwbarton