Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.BigOperators.Ring #1645

Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - feat: port Algebra.BigOperators.Ring #1645

wants to merge 14 commits into from

Conversation

LukasMias
Copy link
Collaborator

@LukasMias LukasMias commented Jan 18, 2023 •
edited by jcommelin

This is done except for some decidability issues in two proofs. I will look into this later, but if this file is of high interest or very critical, feel free to overtake me!

Open in Gitpod

@LukasMias LukasMias added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 18, 2023
@LukasMias LukasMias added the help-wanted The author needs attention to resolve issues label Jan 18, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 18, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 18, 2023
@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Jan 19, 2023
jcommelin
jcommelin approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 19, 2023
bors bot pushed a commit that referenced this pull request Jan 19, 2023
@LukasMias @ChrisHughes24 @jcommelin
feat: port Algebra.BigOperators.Ring (#1645)
12aa913 
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jan 19, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.BigOperators.Ring [Merged by Bors] - feat: port Algebra.BigOperators.Ring Jan 19, 2023
@bors bors bot closed this Jan 19, 2023
@bors bors bot deleted the port/Algebra.BigOperators.Ring branch January 19, 2023 11:42
jcommelin added a commit that referenced this pull request Jan 23, 2023
@LukasMias @ChrisHughes24 @jcommelin
feat: port Algebra.BigOperators.Ring (#1645)
fa05cc9 
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LukasMias @jcommelin @semorrison @ChrisHughes24