Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat port: Data.Set.Pointwise.BigOperators #1651

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat port: Data.Set.Pointwise.BigOperators #1651

wants to merge 8 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Jan 18, 2023

Open in Gitpod

@xroblot xroblot added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 18, 2023
@xroblot xroblot added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 18, 2023
dupuisf
dupuisf reviewed Jan 18, 2023
View reviewed changes
Mathlib/Data/Set/Pointwise/BigOperators.lean
· rintro ⟨g, hg, rfl⟩
exact ⟨g i, is.prod g, hg (is.mem_insert_self _),
⟨⟨g, fun hi ↦ hg (Finset.mem_insert_of_mem hi), rfl⟩, rfl⟩⟩
#align set.mem_finset_prod Set.mem_finset_prod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corresponding align tags have to be added for the theorems generated by to_additive. (If you're not sure what they are, you can replace to_additive by to_additive? and see what it outputs.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.

I have added the align for the lemmas generated by to_additive. I did not do that in my previous PR. So I wonder why is it necessary to do it for this one? Is it because they cannot be auto-generated for some reason?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was also necessary in previous PRs, it's just very easy to overlook :-) There are more details in the porting wiki, there's a whole section about to_additive.

@dupuisf dupuisf added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 18, 2023
@xroblot xroblot added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 18, 2023
dupuisf
dupuisf reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 18, 2023
bors bot pushed a commit that referenced this pull request Jan 18, 2023
@xroblot
feat port: Data.Set.Pointwise.BigOperators (#1651)
161281a
@bors
Copy link

bors bot commented Jan 18, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat port: Data.Set.Pointwise.BigOperators [Merged by Bors] - feat port: Data.Set.Pointwise.BigOperators Jan 18, 2023
@bors bors bot closed this Jan 18, 2023
@bors bors bot deleted the port/Data.Set.Pointwise.BigOperators branch January 18, 2023 23:36
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@xroblot @jcommelin
feat port: Data.Set.Pointwise.BigOperators (#1651)
900dfc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xroblot @dupuisf @semorrison