[Merged by Bors] - feat: port Data.Nat.Parity #1661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
the
awaiting-author
urkud
added
awaiting-review
semorrison
added
the
merge-conflict
|
👎 Rejected by label |
|
@jcommelin I think, we should wait till I resolve issues in the mathlib 3 PR and sync the changes back to mathlib 4. |
urkud
added
awaiting-author
semorrison
removed
the
merge-conflict
urkud
added
awaiting-review
2 tasks
bors bot
pushed a commit
to leanprover-community/mathlib
that referenced
this pull request
Jan 23, 2023
Sync `mathlib3` with API changes introduced while porting `data.nat.parity` to Mathlib 4 in leanprover-community/mathlib4#1661. * Add `even.two_dvd`, `even.trans_dvd`, `has_dvd.dvd.even`, `odd.of_dvd_nat`, and `odd.ne_two_of_dvd_nat`. * Rename `nat.even_sub_one_of_prime_ne_two` to `nat.prime.even_sub_one`, move to `data.nat.prime`. * Delete `odd.factors_ne_two`. * Replace `is_primitive_root.pow_sub_one_norm_prime_pow_of_one_le` with `is_primitive_root.pow_sub_one_norm_prime_pow_of_ne_zero`, assume `≠ 0` instead of `1 ≤`.
Ruben-VandeVelde
approved these changes
Jan 24, 2023
|
This is ready. |
semorrison
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
Backported in leanprover-community/mathlib#18221. Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported in leanprover-community/mathlib#18221.