Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Fintype.Card #1668

Closed
wants to merge 19 commits into from
Closed

[Merged by Bors] - feat: port Data.Fintype.Card #1668

wants to merge 19 commits into from

Conversation

jcommelin
Copy link
Member

Open in Gitpod

@jcommelin jcommelin added the mathlib-port This is a port of a theory file from mathlib. label Jan 19, 2023
@ChrisHughes24 ChrisHughes24 added the awaiting-review The author would like community review of the PR label Jan 19, 2023
jcommelin
jcommelin commented Jan 19, 2023
View reviewed changes
Copy link
Member Author

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 19, 2023
bors bot pushed a commit that referenced this pull request Jan 19, 2023
@jcommelin @ChrisHughes24
feat: port Data.Fintype.Card (#1668)
cd8f5ab 
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented Jan 19, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Fintype.Card [Merged by Bors] - feat: port Data.Fintype.Card Jan 19, 2023
@bors bors bot closed this Jan 19, 2023
@bors bors bot deleted the port/Data.Fintype.Card branch January 19, 2023 11:50
jcommelin added a commit that referenced this pull request Jan 23, 2023
@jcommelin @ChrisHughes24
feat: port Data.Fintype.Card (#1668)
89f607d 
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
@dwrensha dwrensha mentioned this pull request Nov 18, 2023
Closed
mathlib-bors bot pushed a commit that referenced this pull request Dec 12, 2023
@dwrensha @YaelDillies
chore: remove workaround natEmbeddingAux_injective_aux in Data.Fintyp…
114d3b7 
…e.Card (#8501)


Data.Fintype.Card was ported in #1668. After that, `wlog` was added in  #2144.
This means that we can now avoid needing the private workaround theorem
`natEmbeddingAux_injective_aux`.



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
awueth pushed a commit that referenced this pull request Dec 19, 2023
@dwrensha @YaelDillies @awueth
chore: remove workaround natEmbeddingAux_injective_aux in Data.Fintyp…
687a7a0 
…e.Card (#8501)


Data.Fintype.Card was ported in #1668. After that, `wlog` was added in  #2144.
This means that we can now avoid needing the private workaround theorem
`natEmbeddingAux_injective_aux`.



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcommelin @semorrison @ChrisHughes24