Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Fintype.Prod #1676

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port Data.Fintype.Prod #1676

wants to merge 6 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde
feat: port Data.Fintype.Prod
098f2d3
@Ruben-VandeVelde
Initial file copy from mathport
8e8b0e3
@Ruben-VandeVelde
automated fixes
8e67b2e 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@Ruben-VandeVelde Ruben-VandeVelde added the mathlib-port This is a port of a theory file from mathlib. label Jan 19, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 19, 2023
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Jan 19, 2023
@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 19, 2023
bors bot pushed a commit that referenced this pull request Jan 19, 2023
@Ruben-VandeVelde
feat: port Data.Fintype.Prod (#1676)
6af2240
@bors
Copy link

bors bot commented Jan 19, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Fintype.Prod [Merged by Bors] - feat: port Data.Fintype.Prod Jan 19, 2023
@bors bors bot closed this Jan 19, 2023
@bors bors bot deleted the port/Data.Fintype.Prod branch January 19, 2023 17:07
jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@Ruben-VandeVelde @jcommelin
feat: port Data.Fintype.Prod (#1676)
326d3af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ruben-VandeVelde @ChrisHughes24 @semorrison